-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support CREATE VIEW ... UnionStmt #572
Conversation
4c3813c
to
e23be0f
Compare
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
=======================================
Coverage 71.77% 71.77%
=======================================
Files 32 32
Lines 7820 7820
=======================================
Hits 5613 5613
Misses 1676 1676
Partials 531 531
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mysql 8.0> create view v as (select * from t union select * from t);
Query OK, 0 rows affected (0.00 sec)
tidb> create view v as (select * from t union select * from t);
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 39 near "union select * from t)"
I think that create view on (union)
syntax should be supported, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Before this:
What is changed and how it works?
After this, create view on
union
and create view on(select)
syntax are supported.Check List
Tests
Code changes
Side effects
N/A
Related changes